New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isRendered to Carousel #448

Merged

MihailTodorov merged 1 commit into master from fix/add-is-rendered-to-carousel

Jul 15, 2024

Contributor

MihailTodorov commented Jul 15, 2024

Self-reviewed and fixed any obvious mistakes, TODOs, removed debugging code, logs, etc
Updated package.json in related components, the library or the cli
Created tests
Tested in a browser
Tested in Gameface
Created or updated the documentation
Transferred or updated the Hugo documentation and example

Remove any item from the list if not applicable by editing this message.


          Add isRendered

337af4b

MihailTodorov requested a review from alien1976

July 15, 2024 13:36

MihailTodorov self-assigned this

alien1976 approved these changes

View reviewed changes

components/carousel/package.json

@@ @@ -1,6 +1,6 @@ @@
               {
                   "name": "coherent-gameface-carousel",
-                  "version": "1.3.0",

Contributor

alien1976 Jul 15, 2024

Shouldn't be 1.3.1 as it is a fix?

MihailTodorov merged commit 90415de into master

3 of 4 checks passed

MihailTodorov deleted the fix/add-is-rendered-to-carousel branch

July 15, 2024 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet