Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adaptive card heading a11y #96

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

sushmi21
Copy link
Contributor

This PR adds aria-level attribute to adaptive card headings. It also modifies the caption label on videos with captions.

Success criteria:

  • When the 'style: heading' is added to a text block in adaptive card, the aria-level=2 attribute should be added to the heading element
  • The video with caption should have the label 'On' in the menu overlay, instead of the label 'English'

How to test:

  • In the demo chat, inspect the adaptive card header. Check if the aria-level=2 attribute is present with the role=heading attribute
  • In the demo, turn on the captions in the video player. Open the secondary menu again and check the label below 'Captions' menu item. It should say 'On' instead of 'English'

@sushmi21 sushmi21 requested a review from kwinto September 26, 2024 13:04
@sushmi21 sushmi21 merged commit 2050457 into main Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants