Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not collate message if prev message is rating #22

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

sushmi21
Copy link
Contributor

@sushmi21 sushmi21 commented Jan 10, 2024

The spacing below the Feedback submitted status pill is incorrect because of collation. So, this PR prevents message collation when the previous message is a rating feedback.

NOTE: Test this PR along with Cognigy/WebchatWidget#363 or after that PR is merged.
How to test:

  • Build & Pack the chat-components folder
  • install the package in webchat widget repo
  • Use an endpoint pointing to a flow with request rating node or use this endpoint: https://endpoint-dev.cognigy.ai/a7f6316334debd965e4668ec402043e3498c69f0146fa4b96f29c059337eeab7
  • Chat with the bot and provide a rating when prompted.
  • After submitting the feedback 'Feedback submitted' status pill will appear in the history
  • Now send another user message.
  • The spacing between the pill and the following user message should be according to figma (Refer to User joined and Meeting confirmed status pills)

BEFORE
before

AFTER
after

@sushmi21 sushmi21 requested review from kwinto and fabclj January 10, 2024 14:43
kwinto
kwinto previously approved these changes Jan 10, 2024
@sushmi21 sushmi21 merged commit c499e64 into main Jan 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants