Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: snapshot tests for demo page covering useful components #112

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vj-venkatesan
Copy link
Contributor

This PR adds snapshot tests for the existing chat components in demo page.

This will be useful for spotting UI regressions during the development phase

@vj-venkatesan vj-venkatesan requested a review from kwinto February 4, 2025 11:56
@kwinto
Copy link
Contributor

kwinto commented Feb 4, 2025

Can you add a script to the package.json for the snapshot update?

And maybe also document this in the Readme? So when we make a legitimate change, and the tests start to fail, we know what to do.

<Demo />
</React.StrictMode>,
);
if (process.env.NODE_ENV === "development") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vitest runs this section of code in test mode and fails to run the test which is the reason this if statement is added

@vj-venkatesan vj-venkatesan marked this pull request as draft February 4, 2025 13:16
@vj-venkatesan vj-venkatesan requested a review from dshire February 4, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants