Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Department members #471

Closed
wants to merge 136 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
136 commits
Select commit Hold shift + click to select a range
4bd3fda
Updated lock file
Rotendahl Jan 27, 2020
31d0ee8
Merge branch 'master' of github.com:Rotendahl/forenings_medlemmer
Rotendahl Feb 8, 2020
e77e853
Merge branch 'master' of https://github.com/CodingPirates/forenings_m…
Rotendahl Feb 8, 2020
94e9f4e
Cleaned SCSS/CSS
Rotendahl Feb 18, 2020
b844165
Begin work on union_overview
JondareHM Feb 19, 2020
50e37ef
Added union_overview and union_members
JondareHM Feb 19, 2020
a670cea
Finished union_overview. May need better styling, not my strong suit.
JondareHM Feb 24, 2020
d37be51
Made Members list based on year, and temprary union.members() spoofer…
JondareHM Feb 24, 2020
93f8751
Merge branch 'master' into department_members
JondareHM Feb 29, 2020
d9e9023
Added Union info. Will need to be updated when #455 is deployed.
JondareHM Mar 2, 2020
69b57d2
Merge branch 'department_members' of https://github.com/JondareHM/for…
JondareHM Mar 2, 2020
144c225
Merge branch 'master' into department_members
JondareHM Mar 2, 2020
e8f6d4b
Added union_overview to entry page, and added some more info
JondareHM Mar 2, 2020
83186ba
Merge branch 'master' of https://github.com/CodingPirates/forenings_m…
Rotendahl Mar 2, 2020
1dd8355
Merge branch 'master' into department_members
Rotendahl Mar 3, 2020
4123fdc
Updated contrib
Rotendahl Mar 3, 2020
e95d17f
Merge branch 'master' of https://github.com/CodingPirates/forenings_m…
Rotendahl Mar 3, 2020
9b6a814
Updated markup
Rotendahl Mar 3, 2020
beebf70
:art: Fix formatting of 2 files for commit 9b6a814
Mar 3, 2020
a3ed9dc
Merge pull request #6 from CodingPirates/unibeautify/pull-request-474
Rotendahl Mar 3, 2020
d5ef0a4
Moved font import
Rotendahl Mar 3, 2020
c86a474
Merge branch 'sass_fix' of github.com:Rotendahl/forenings_medlemmer i…
Rotendahl Mar 3, 2020
fb1fcb1
:art: Fix formatting of 1 file for commit c86a474
Mar 3, 2020
aae153e
Merge pull request #7 from CodingPirates/unibeautify/pull-request-474
Rotendahl Mar 3, 2020
296aa8b
Merge branch 'master' of https://github.com/CodingPirates/forenings_m…
Rotendahl Mar 4, 2020
966e445
Merge branch 'master' into sass_fix
Rotendahl Mar 5, 2020
6b2fdec
Merge branch 'master' of https://github.com/CodingPirates/forenings_m…
Rotendahl Mar 5, 2020
779c47b
Merge branch 'department_members' of github.com:JondareHM/forenings_m…
Rotendahl Mar 5, 2020
436c1a9
Merge branch 'sass_fix' of github.com:Rotendahl/forenings_medlemmer i…
Rotendahl Mar 5, 2020
d75a3cd
Added scss for union_overview, added log in log out test
Rotendahl Mar 5, 2020
b1db6a0
Merge branch 'master' into department_members
Rotendahl Mar 5, 2020
6266038
Working on checking user union relationship
JondareHM Mar 9, 2020
5762d23
Work on the look of the members view
JondareHM Mar 16, 2020
28d53f5
Added meeting_notes field to union, finished scss, and made leader ch…
JondareHM Mar 19, 2020
9b19cba
Merge branch 'master' into department_members
JondareHM Mar 19, 2020
2596bb5
beautify
JondareHM Mar 19, 2020
37f1110
Merge branch 'department_members' of https://github.com/JondareHM/for…
JondareHM Mar 19, 2020
b8aa68c
more beautify
JondareHM Mar 19, 2020
1e8017f
Deleted migration 10, and fixed sass error
JondareHM Mar 19, 2020
1256774
Fixed unused imports
JondareHM Mar 19, 2020
c4a408c
Merge branch 'master' into department_members
Rotendahl Mar 25, 2020
2412bcc
Merge branch 'master' into department_members
JondareHM Mar 30, 2020
38eacfd
union.members() working, but can't figure out how to eliminate duplic…
JondareHM Mar 30, 2020
d8bc29f
fixed import
JondareHM Mar 30, 2020
b421c26
fixed import attempt #2
JondareHM Mar 30, 2020
6481c94
Eliminates duplicates
JondareHM Mar 30, 2020
2d0c3a3
Fixed personfactory and familyfactory having a max number
JondareHM Apr 2, 2020
aa91555
Merge branch 'master' into department_members
JondareHM Apr 2, 2020
a3a2fd9
Merge branch 'master' into department_members
JondareHM Apr 2, 2020
80d59bc
old factory fix didn't work, this one does
JondareHM Apr 2, 2020
204fb36
THERE. factory created emails fixed
JondareHM Apr 2, 2020
e80348c
forgot to remove factory.
JondareHM Apr 2, 2020
55f2f01
Merge branch 'master' into department_members
Rotendahl Apr 7, 2020
af4c32f
Various small fixes, and updated union_overview to use the Tabs
JondareHM Apr 15, 2020
e8c2f28
Merge branch 'department_members' of https://github.com/JondareHM/for…
JondareHM Apr 15, 2020
5564e1b
Merge branch 'master' of https://github.com/CodingPirates/forenings_m…
JondareHM Apr 20, 2020
ed64828
deleted unibeatify
JondareHM Apr 20, 2020
c713a55
added default to union.founded
JondareHM Apr 21, 2020
384720e
Merge branch 'master' into department_members
JondareHM Apr 28, 2020
ba079fd
small changes
JondareHM May 4, 2020
0402027
Merge branch 'department_members' of https://github.com/JondareHM/for…
JondareHM May 4, 2020
a31731c
fix get_live_data
JondareHM May 4, 2020
6f63f6d
json fix
JondareHM May 4, 2020
18443d5
actually saves the json now
JondareHM May 4, 2020
0cb0e5b
json
JondareHM May 4, 2020
d13cd53
finally fixed json
JondareHM May 4, 2020
52791ef
fixed tabs
JondareHM May 5, 2020
d596aef
tabs
JondareHM May 5, 2020
0ba5d21
Merge branch 'master' into department_members
JondareHM May 11, 2020
f3ccd8f
Finally fixed the issues on union_overview
JondareHM May 11, 2020
d9df4bd
Merge branch 'master' into department_members
JondareHM May 12, 2020
0f6917a
Merge branch 'master' into department_members
JondareHM May 25, 2020
7f49ca7
Fixed the irritating tab errors.
JondareHM May 25, 2020
b07dbcc
Merge branch 'master' into department_members
JondareHM May 26, 2020
4a8ff06
Merged migrations
JondareHM May 26, 2020
7968660
Updated to work with Foreningsledere_fix
JondareHM May 26, 2020
b03efa8
black
JondareHM May 26, 2020
ab1f6f6
Remowed old boards from union_admin, and fixed the factory
JondareHM May 26, 2020
ce478ca
remowed unused import
JondareHM May 26, 2020
706f4f1
Merge branch 'master' into department_members
JondareHM Jun 2, 2020
1c9bd75
Merge branch 'master' into department_members
JondareHM Jun 8, 2020
12a6657
fixed indent
JondareHM Jun 8, 2020
4e72774
Merge branch 'master' into department_members
JondareHM Jun 15, 2020
1cfc45f
merged migrations
JondareHM Jun 15, 2020
b78463b
Merge branch 'department_members' of https://github.com/JondareHM/for…
JondareHM Jun 15, 2020
64b6d9c
Made missing migrations
JondareHM Jun 15, 2020
a21e1f8
ran black
JondareHM Jun 15, 2020
5d1250e
More tests of union_overview and union_members
JondareHM Jun 16, 2020
ece1d68
Flake8
JondareHM Jun 16, 2020
a3f163f
Added "reverse" option to tabs, which makes the rightmost tab the def…
JondareHM Jun 24, 2020
00c4d8c
Merge branch 'master' into department_members
JondareHM Jun 24, 2020
94fa2ae
fixed test to work with new default
JondareHM Jun 24, 2020
dc41876
Test fixed
JondareHM Jun 24, 2020
f7a2300
Merge branch 'master' into department_members
JondareHM Jul 6, 2020
86af72b
Merge branch 'master' into department_members
JondareHM Jul 13, 2020
8373dc8
Merge branch 'master' into department_members
JondareHM Aug 3, 2020
de57fc1
Merge branch 'master' into department_members
JondareHM Aug 10, 2020
2056da9
Merge branch 'master' into department_members
Rotendahl Aug 12, 2020
81b2db3
Updated union_user_is_leader
Rotendahl Aug 14, 2020
e1635e3
Updated text
Rotendahl Aug 14, 2020
754bfc2
Merge branch 'master' into department_members
JondareHM Sep 7, 2020
d71c4b6
Small changes based on Rotendahl Review
JondareHM Sep 7, 2020
3ce6b1d
Merge branch 'department_members' of https://github.com/JondareHM/for…
JondareHM Sep 7, 2020
fcd8991
merged migrations
JondareHM Sep 7, 2020
1837a6d
Fixed some imports
JondareHM Sep 7, 2020
01bdb4e
Fixed link to union page so it's no longer hardcoded
JondareHM Sep 7, 2020
7af579e
Changed the date used for union.members, since the old one was appare…
JondareHM Sep 7, 2020
a44fa47
testing if it's the members table that causes error by removing it.
JondareHM Sep 14, 2020
3abd24d
Trying the old date version again
JondareHM Sep 14, 2020
302d1df
make datetime timezone aware
JondareHM Sep 14, 2020
18d8c51
timezone.datetime
JondareHM Sep 14, 2020
b78b242
testing the union.members function
JondareHM Sep 14, 2020
f2b3e1a
test
JondareHM Sep 14, 2020
091e242
tests
JondareHM Sep 14, 2020
917a2ef
test
JondareHM Sep 14, 2020
e460090
test
JondareHM Sep 14, 2020
5e268f6
actually searches for the correct thing now
JondareHM Sep 14, 2020
c4468fc
test why union() no longer shows the first
JondareHM Sep 14, 2020
3526a22
should work now
JondareHM Sep 14, 2020
126ec1f
test members
JondareHM Sep 14, 2020
19abfa6
try to make members table show up
JondareHM Sep 14, 2020
d1cbfa1
tests
JondareHM Sep 22, 2020
0d0065e
tests
JondareHM Sep 22, 2020
766ae66
Merge branch 'master' into department_members
JondareHM Sep 22, 2020
8d428cb
Fixed wrong import in factories.
JondareHM Sep 22, 2020
5a005b3
Fix department list test and remove debug prints
JondareHM Sep 22, 2020
77d7180
updated Black
JondareHM Sep 22, 2020
c7f2c3b
removed unused import
JondareHM Sep 22, 2020
3bbb4e9
Fixed JS and hopefully made union_members run faster and more efficie…
JondareHM Sep 28, 2020
17ef08a
changed membertype in list
JondareHM Sep 28, 2020
40aece6
fixed the queryset filters
JondareHM Sep 28, 2020
3c98f60
using select_related() to try and make the querysets more efficient
JondareHM Oct 12, 2020
5e4e613
Merge branch 'master' into department_members
JondareHM Oct 12, 2020
34ee543
Tester forældre email inklusion
JondareHM Oct 19, 2020
daa6777
virkede ikke, revert
JondareHM Oct 19, 2020
f2a59df
Merge branch 'master' into department_members
JondareHM Nov 30, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions members/admin/union_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def get_queryset(self, request):
},
),
(
"Bestyrelsen nye felter",
"Bestyrelsen",
{
"fields": (
"chairman",
Expand All @@ -40,28 +40,20 @@ def get_queryset(self, request):
)
},
),
(
"Bestyrelsen gamle felter",
{
"fields": (
"chairman_old",
"chairman_email_old",
"second_chair_old",
"second_chair_email_old",
"cashier_old",
"cashier_email_old",
"secretary_old",
"secretary_email_old",
"board_members_old",
)
},
),
(
"Info",
{
"fields": ("bank_main_org", "bank_account", "statues", "founded"),
"description": "Indsæt et link til jeres vedtægter, hvornår I er stiftet (har holdt stiftende \
generalforsamling) og jeres bankkonto hvis I har sådan en til foreningen.",
"fields": (
"bank_main_org",
"bank_account",
"statues",
"meeting_notes",
"founded",
),
"description": """
Indsæt et link til jeres vedtægter, jeres seneste referater, \
hvornår I er stiftet (har holdt stiftende generalforsamling) \
og jeres bankkonto hvis I har sådan en til foreningen.""",
},
),
]
Expand Down
4 changes: 2 additions & 2 deletions members/management/commands/create_membership_activitys.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ def handle(self, *args, **options):
union=curUnion,
name=name,
open_hours=open_hours,
responsible_name=curUnion.chairman_old,
responsible_contact=curUnion.chairman_email_old,
responsible_name=curUnion.chairman.name,
responsible_contact=curUnion.chairman.email,
placename=curUnion.address.placename,
zipcode=curUnion.address.zipcode,
city=curUnion.address.city,
Expand Down
5 changes: 4 additions & 1 deletion members/management/commands/get_live_data.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
from zipfile import ZipFile
import os
import json
import os
from django.core.management.base import BaseCommand
from django.core.management import call_command
from django.db import DatabaseError
from members.models import Department, Union, Address, Person
from members.tests.factories import PersonFactory
import requests
import shutil
import datetime

from .dump_public_data import MODELS_TO_DUMP as MODELS_TO_LOAD

Expand Down Expand Up @@ -48,6 +49,8 @@ def handle(self, *args, **options):
union_json = json.load(union_file)

for union in union_json:
if union["fields"]["founded"] is None:
union["fields"]["founded"] = str(datetime.date(1970, 1, 1))
union["fields"].pop("region", None)
union["fields"].pop("REGION_CHOICES", None)
_create_person_with_id(union["fields"]["chairman"])
Expand Down
20 changes: 20 additions & 0 deletions members/migrations/0020_union_meeting_notes.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Generated by Django 2.2.9 on 2020-03-19 10:23

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("members", "0019_auto_20200211_1457"),
]

operations = [
migrations.AddField(
model_name="union",
name="meeting_notes",
field=models.URLField(
blank=True, verbose_name="Link til seneste referater"
),
),
]
22 changes: 22 additions & 0 deletions members/migrations/0021_auto_20200421_1313.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Generated by Django 2.2.9 on 2020-04-21 11:13

from django.db import migrations, models
import datetime


class Migration(migrations.Migration):

dependencies = [
("members", "0020_union_meeting_notes"),
]

operations = [
migrations.AlterField(
model_name="union",
name="founded",
field=models.DateField(
default=datetime.datetime(1970, 1, 1), verbose_name="Stiftet"
),
preserve_default=False,
),
]
13 changes: 13 additions & 0 deletions members/migrations/0022_merge_20200526_1131.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Generated by Django 2.2.9 on 2020-05-26 09:31

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
("members", "0021_auto_20200309_1107"),
("members", "0021_auto_20200421_1313"),
]

operations = []
13 changes: 13 additions & 0 deletions members/migrations/0023_merge_20200615_1116.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Generated by Django 2.2.9 on 2020-06-15 09:16

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
("members", "0022_merge_20200526_1131"),
("members", "0022_merge_20200526_1130"),
]

operations = []
18 changes: 18 additions & 0 deletions members/migrations/0024_auto_20200615_1244.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Generated by Django 2.2.9 on 2020-06-15 10:44

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("members", "0023_merge_20200615_1116"),
]

operations = [
migrations.AlterField(
model_name="union",
name="founded",
field=models.DateField(blank=True, null=True, verbose_name="Stiftet"),
),
]
13 changes: 13 additions & 0 deletions members/migrations/0025_merge_20200907_1209.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Generated by Django 3.0.8 on 2020-09-07 10:09

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
("members", "0024_auto_20200615_1244"),
("members", "0024_auto_20200902_1108"),
]

operations = []
77 changes: 75 additions & 2 deletions members/models/union.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
from django.db import models
from .payment import Payment
from .activity import Activity
from .department import Department
from .activityparticipant import ActivityParticipant
from django.core.exceptions import ValidationError
from django.core.validators import RegexValidator
from django.utils import timezone
from django.utils.timezone import make_aware
from datetime import timedelta
from django.db.models import F
import datetime


class Union(models.Model):
Expand All @@ -12,6 +19,8 @@ class Meta:
ordering = ["name"]

name = models.CharField("Foreningens navn", max_length=200)
meeting_notes = models.URLField("Link til seneste referater", blank=True)
founded = models.DateField("Stiftet")
chairman = models.ForeignKey(
"Person",
on_delete=models.PROTECT,
Expand Down Expand Up @@ -79,3 +88,67 @@ def clean(self):
raise ValidationError(
"Vælg om foreningen har konto hos hovedforeningen. Hvis ikke skal bankkonto udfyldes."
)

def members(self):
years = range(self.founded.year, (timezone.now().date()).year + 1)
members = {}
departments = Department.objects.filter(union=self.id)
union_activities_filter = Activity.objects.filter(
member_justified=True,
)
union_activities_1_filter = union_activities_filter.filter(
department__in=departments,
end_date__gt=F("start_date") + timedelta(days=2),
)
union_activities_2_filter = union_activities_filter.filter(
union_id=self.id,
)
payment_filter = Payment.objects.filter(
amount_ore__gte=7500,
refunded_dtm__isnull=True,
)
participant_filter = ActivityParticipant.objects.all().select_related(
"activity", "member__person"
)
for year in years:
temp_members = []
union_activities_1 = union_activities_1_filter.filter(
start_date__year=year,
)
union_activities_2 = union_activities_2_filter.filter(
start_date__year=year,
).union(union_activities_1)
payment_filter_1 = payment_filter.filter(
confirmed_dtm__lte=make_aware(datetime.datetime(year, 9, 30)),
).select_related("activity", "activityparticipant")
for activity in union_activities_2:
payment_filter_2 = payment_filter_1.filter(
activity=activity,
)
for participant in participant_filter.filter(
activity=activity
).distinct():
if (
payment_filter_2.filter(
person=participant.member.person,
).count()
> 0
):
temp_members.append(participant.member.person)
members[year] = temp_members
return members

def user_union_leader(self, user):
people_on_board = [person.user for person in self.board_members.all()]
board_posistions = [
self.chairman,
self.second_chair,
self.cashier,
self.secretary,
]
board_posistions = [
position.user for position in board_posistions if position is not None
]
return user is not None and (
user.is_superuser or user in people_on_board + board_posistions
)
12 changes: 8 additions & 4 deletions members/static/members/js/tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,12 @@ document.addEventListener("DOMContentLoaded", function(event) {
Array.from(tabs.children).filter(element => element.tagName === "SECTION")
);

// Default to first as active
toggleActive(sections, tabButtons, 0);
// Default to first as active, unless "reverse" class then set last as active
if(document.getElementsByClassName("tabs reverse").length != 0){
toggleActive(sections, tabButtons, tabButtons.length-1);
}else{
toggleActive(sections, tabButtons, 0);
}

for (var button of tabButtons) {
button.addEventListener("click", event =>
Expand All @@ -25,8 +29,8 @@ function toggleActive(sections, buttons, activeIndex) {
button.classList.remove("tab-active");
}
for (var section of sections) {
section.hidden = true;
section.className = section.classList.remove("tab-section-active");
}
buttons[activeIndex].classList.add("tab-active");
sections[activeIndex].hidden = false;
sections[activeIndex].classList.add("tab-section-active");
}
4 changes: 3 additions & 1 deletion members/static/members/sass/main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
@use "header";
@use "login";
@use "style";
@use "union_members";
@use "table";
@use "tab";
@use "union_overview";
@use "department_list";
@import url("https://fonts.googleapis.com/css?family=Bungee|Lato|Pirata+One&display=swap");
@import url("https://fonts.googleapis.com/css?family=Bungee|Lato|Pirata+One&display=swap");
6 changes: 6 additions & 0 deletions members/static/members/sass/tab.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,10 @@
}
}
}
> section {
display: none;
&.tab-section-active {
display: block;
}
}
}
33 changes: 33 additions & 0 deletions members/static/members/sass/union_members.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
@use "_definitions";

#union_info {
@extend %container;
margin-bottom: 40px;
> div {
> h4 {
display: flex;
justify-content: center;
}
> div {
border: 1px solid #dee2e6 !important;
font-size: 1.2em;
display: flex;
justify-content: space-around;
> div {
ul {
list-style-type: none;
margin: 10px 0;
}
}
}
}
}

#union_documents {
display: flex;
margin-bottom: 40px;
justify-content: space-around;
a {
@extend %button !optional;
}
}
16 changes: 16 additions & 0 deletions members/static/members/sass/union_overview.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
@use "_definitions";

.union_list {
display: grid;
grid-template-rows: auto;
justify-content: stretch;
@include _definitions.for-desktop{
grid-template-columns: repeat(3, 1fr);
}
@include _definitions.for-phone{
grid-template-columns: repeat(1, 1fr);
}
> ul{
list-style: none;
}
}
Loading