Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): Add ClubsSealIcon #2983

Merged
merged 3 commits into from
Dec 17, 2024
Merged

feat(Icons): Add ClubsSealIcon #2983

merged 3 commits into from
Dec 17, 2024

Conversation

mstykmshy
Copy link
Contributor

@mstykmshy mstykmshy commented Dec 6, 2024 •
edited
Loading

Overview

Adds ClubsSealIcon

PR Checklist

Testing Instructions

To see in Storybook, visit https://67531630c4c4826ed1ffd7ca--gamut-preview.netlify.app/?path=/docs/atoms-icons-regular--editable-icons

To see in use in the dashboard, run the sk-LEGO-4158-dashboard-feature-card-update monorepo branch locally and scroll down to the "Discover More Features' section at /learn

Screenshot 2024-12-06 at 10 53 28 AM

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Icon isn't in the preview env as it's for a contentful change that isn't published yet, see instructions above to view locally

@mstykmshy mstykmshy changed the title feat(Icons) Add ClubsSealIcon feat(Icons): Add ClubsSealIcon Dec 6, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 5213c3c.
Please verify you are running the latest version of the NxCloud runner.

Check the Nx Cloud Source Control Integration documentation for more information.

Alternatively, you can contact us at [email protected].

Sent with 💌 from NxCloud.

@mstykmshy mstykmshy marked this pull request as ready for review December 6, 2024 16:06
@mstykmshy mstykmshy requested a review from a team as a code owner December 6, 2024 16:06
dreamwasp
dreamwasp approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! you can run yarn format --fix to resolve the lint issues (we're fixing this in our upcoming storybook change)

@mstykmshy
Copy link
Contributor Author

lgtm ! you can run yarn format --fix to resolve the lint issues (we're fixing this in our upcoming storybook change)

ahh tysm @dreamwasp ! 🙏

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://675c7ca328119a6401771018--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@mstykmshy mstykmshy added the Ship It :shipit: Automerge this PR when possible label Dec 17, 2024
@codecademydev codecademydev merged commit 50bb6ce into main Dec 17, 2024
15 of 16 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Dec 17, 2024
@codecademydev codecademydev deleted the sk-lego-4158-add-clubs-icon branch December 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

@LinKCoding LinKCoding Awaiting requested review from LinKCoding LinKCoding is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstykmshy @codecademydev @dreamwasp