Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(FormGroup): Use correct required prop in FormGroup storybook examples #2927

Merged
merged 2 commits into from
Aug 22, 2024
Merged

docs(FormGroup): Use correct required prop in FormGroup storybook examples #2927

merged 2 commits into from
Aug 22, 2024

Conversation

aresnik11
Copy link
Contributor

@aresnik11 aresnik11 commented Aug 21, 2024 •
edited
Loading

Overview

Updates the FormGroup examples to accurately mark form inputs as required to match their label

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-850
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Visit the storybook preview
  2. Under FormGroup states see that the inputs are marked as required with an asterisks (which matches the label text)

@aresnik11 aresnik11 requested a review from a team as a code owner August 21, 2024 21:08
@aresnik11 aresnik11 requested review from timjenkins, BandanaKM and dreamwasp and removed request for timjenkins and BandanaKM August 21, 2024 21:08
dreamwasp
dreamwasp approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm! the yarn verify check that' failing can be fixed by running yarn format --fix and committing the result (prettier doesn't always play nice with mdx 🤷 )

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]

@aresnik11 aresnik11 added the Ship It :shipit: Automerge this PR when possible label Aug 22, 2024
@codecademydev codecademydev merged commit 73f3970 into main Aug 22, 2024
16 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Aug 22, 2024
@codecademydev codecademydev deleted the ajr-update-form-group-examples branch August 22, 2024 13:50
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66c74280616fe42ff23c84dd--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aresnik11 @codecademydev @dreamwasp