Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Button): Adding guidance note for TextButton #2924

Merged
merged 1 commit into from
Aug 7, 2024
Merged

docs(Button): Adding guidance note for TextButton #2924

merged 1 commit into from
Aug 7, 2024

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Aug 7, 2024 •
edited by jira bot
Loading

Overview

Adding a guidance note for TextButton

PR Checklist

  • Related to JIRA ticket: GM-631
  • I have run this code to verify it works

Testing Instructions

  1. Go to the preview's ?path=/docs/atoms-button--text-button section
  2. Check that the text is there (proofread as well?)
  3. ...
  4. Profit!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]

@LinKCoding LinKCoding changed the title doc(Button): Adding guidance note for TextButton docs(Button): Adding guidance note for TextButton Aug 7, 2024
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66b38e562868bf09d03baa7d--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding marked this pull request as ready for review August 7, 2024 15:12
@LinKCoding LinKCoding requested a review from a team as a code owner August 7, 2024 15:12
aresnik11
aresnik11 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the text is there and proofread it 😂 ✨

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Aug 7, 2024
@codecademydev codecademydev merged commit 777d414 into main Aug 7, 2024
27 of 30 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Aug 7, 2024
@codecademydev codecademydev deleted the kl-gm-631 branch August 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinKCoding @codecademydev @aresnik11