Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Border Radius): Fixing Atoms' border radii #2921

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Aug 6, 2024

Overview

Addressing the atoms first, fixing border radii
See notion for more details: https://www.notion.so/codecademy/Border-Radius-Tracker-55c1c9e9ab49480995d314ac3fb784ff

PR Checklist

  • Related to designs:
  • Related to a mixture of JIRA tickets: GM-592, GM-892, GM-828, GM-830
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Visit the notion page to see a list of changed components, go to their relative paths and check that things render the same and work the same way.

@LinKCoding LinKCoding marked this pull request as ready for review August 6, 2024 13:14
@LinKCoding LinKCoding requested a review from a team as a code owner August 6, 2024 13:14
@LinKCoding LinKCoding requested review from BandanaKM, aresnik11 and dreamwasp and removed request for a team August 6, 2024 13:14
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some code-only review comments, gonna test locally in a bit

@LinKCoding LinKCoding added Ship It :shipit: Automerge this PR when possible and removed Ship It :shipit: Automerge this PR when possible labels Aug 6, 2024
@LinKCoding LinKCoding merged commit 6ad1890 into kl-gm-592 Aug 6, 2024
6 of 15 checks passed
@LinKCoding LinKCoding deleted the kl-gm-592-border-radius-atoms branch August 6, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants