Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dialog): a new optional prop for the close button #2916

Merged
merged 6 commits into from
Aug 14, 2024
Merged

feat(Dialog): a new optional prop for the close button #2916

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
24fb2ca
feat(Dialog): added two optional props for the close button label and…
ITZSHOAIB Jul 31, 2024
b67490e
feat(Dialog): removed aria-label from the close button
ITZSHOAIB Jul 31, 2024
2b7787f
test(Dialog): updated the test case to get the element by default label
ITZSHOAIB Aug 1, 2024
88b31fe
Merge branch 'main' into ss-dialog-props
dreamwasp Aug 1, 2024
7916db4
Merge branch 'main' into ss-dialog-props
smithgajjar09 Aug 13, 2024
3727323
Merge branch 'main' into ss-dialog-props
dreamwasp Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/gamut/src/Modals/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ export interface DialogProps extends ModalBaseProps {
>;
confirmCta: DialogButtonProps;
cancelCta?: DialogButtonProps;
closeButtonLabel?: string;
closeButtonTipText?: string;
}

export const Dialog: React.FC<DialogProps> = ({
Expand All @@ -36,6 +38,8 @@ export const Dialog: React.FC<DialogProps> = ({
onRequestClose,
image,
size = 'small',
closeButtonLabel = 'Close Dialog',
closeButtonTipText = 'Close dialog',
...rest
}) => {
const onConfirm: DialogButtonProps['onClick'] = (
Expand Down Expand Up @@ -69,12 +73,12 @@ export const Dialog: React.FC<DialogProps> = ({
</Text>
<Box gridArea="close">
<IconButton
aria-label="Close Dialog"
aria-label={closeButtonLabel}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can delete this line, i don't think it needs an aria-label, the tip text should be enough (it auto-adds aria-label based on tip text)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in the latest commit. Thanks!

size="small"
alignSelf="start"
icon={MiniDeleteIcon}
onClick={onCancel}
tip="Close dialog"
tip={closeButtonTipText}
/>
</Box>
<Box as="div" gridArea="content" data-testid="dialog-content">
Expand Down
Loading