Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InfoTip): fix DOM ordering + tip not being reread #2909

Merged
merged 19 commits into from
Jul 22, 2024
Merged

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jul 11, 2024

Overview

Fixes DOM ordering and Infotip not being re-read on retrigger (known issue with aria-live on Chrome)

i've found that properly fixing the floating alignment would require an entire overhaul of the Popover component -- i've caught a larger epic for that here.

instead, the user can tab through the screenreader text for the floating component which does respect DOM order - giving the user the correct information in the correct order even if its not the same HTML element. this is a quick fix, i'm planning for a long-term fix with the adjustments to the Popover component but thats a much larger effort.

PR Checklist

  • Related to JIRA ticket: [gm-788, ENT-73]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Head to InfoTip story
  2. Turn on VO
  3. Trigger an InfoTip at least 3x times - you should hear it read each re-trigger
  4. Navigate to the alignment section
  5. Open a top-aligned infotip
  6. You should be able to hear the tip announced, and navigate through the text in correct DOM order using CTRL + OPT
  7. Open a bottom-aligned infotip
  8. You should be able to hear the tip announced, and navigate through the text in correct DOM order using CTRL + OPT
  9. Navigate to the floating section
  10. You should be able to hear the tip announced, and navigate through the text in correct DOM order using CTRL + OPT. The tip will not be highlighted, though the information should be communicated in the correct order.
  11. Navigate to ToolTip page
  12. You should only hear tips communicated as the Buttons and not repeated when navigating with CTRL + OPT
  13. Profit

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@dreamwasp dreamwasp requested a review from andleebsyed July 11, 2024 20:49
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6696b309b4404cfc93855779--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp marked this pull request as ready for review July 18, 2024 15:41
@dreamwasp dreamwasp requested a review from a team as a code owner July 18, 2024 15:41
@dreamwasp dreamwasp requested review from timjenkins, BandanaKM and a team July 18, 2024 15:41
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected ✨

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Jul 22, 2024
@codecademydev codecademydev merged commit 08e8b6a into main Jul 22, 2024
23 of 24 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 22, 2024
@codecademydev codecademydev deleted the cass-gm-788 branch July 22, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants