Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_jvm_external to fix POM #924

Merged
merged 4 commits into from
Jan 19, 2025

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 17, 2025

Requires updating a few deps, which in turn adds more checks to ktlint. Most of them can be fixed automatically (see commits 2 and 3, reviewing with "Hide whitespace" makes this more manageable), very few need manual suppression (commit 4).

Work towards #919

Copy link
Contributor

@oetr oetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@oetr oetr merged commit fed0080 into CodeIntelligenceTesting:main Jan 19, 2025
5 checks passed
@fmeum fmeum deleted the fix-pom-scope branch January 21, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants