Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added real-time cursor location to status bar #1514

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Added real-time cursor location to status bar #1514

merged 1 commit into from
Dec 21, 2023

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Dec 21, 2023 •
edited
Loading

Description

The real-time cursor position, selected character count, and selected line count is now displayed in the status bar.

Related Issues

Checklist

  • Add cursor location (line and column)
  • Add character count
  • Add line count
  • Add selected range count (could not test because multiple cursors currently doesn't work)
  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2023-12-21.at.12.20.03.AM.mov
Screen.Recording.2023-12-21.at.12.30.58.AM.mov
Screen.Recording.2023-12-21.at.12.23.32.AM.mov

0xWDG
0xWDG approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@austincondiff austincondiff merged commit 235ea68 into CodeEditApp:main Dec 21, 2023
2 checks passed
@0xWDG 0xWDG linked an issue Dec 21, 2023 that may be closed by this pull request
🐞 Cursor position in status bar doesn't work #1513
Closed
@0xWDG 0xWDG mentioned this pull request Dec 21, 2023
Closed
@thecoolwinter thecoolwinter added the enhancement New feature or request label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@matthijseikelenboom matthijseikelenboom matthijseikelenboom approved these changes

@LeoBorai LeoBorai Awaiting requested review from LeoBorai

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@KaiTheRedNinja KaiTheRedNinja Awaiting requested review from KaiTheRedNinja

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Cursor position in status bar doesn't work
4 participants
@austincondiff @0xWDG @matthijseikelenboom @thecoolwinter