Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1484 Search Results are in lowercases letters : Fixed #1495

Closed
wants to merge 1 commit into from

Conversation

deepal15
Copy link

Description

When conducting a search, I observed that the search results are displaying text in lowercase, deviating from the original case of the text.
Fix: While appending found cases to main result data, it should be in the same case as it is present in the actual file

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screenshot 2023-11-26 at 9 09 46 PM

While appending found case to main result data, it should be in the same case as it is present in the actual file
@LeoBorai LeoBorai requested a review from a team November 26, 2023 16:31
@LeoBorai LeoBorai requested a review from a team November 26, 2023 16:32
@tom-ludwig
Copy link
Member

Thanks for the pull request! The indexing/search PR I submitted for review will address this issue tho. Apologies for overlooking the inclusion of the issue in my PR description. Appreciate your understanding.

@austincondiff
Copy link
Collaborator

@deepal15 thank you for the effort but as @activcoding said, it has already been done. We really appreciate your efforts! Closing in favor of #1483 to avoid conflicts.

@tom-ludwig
Copy link
Member

@deepal15 sorry again—this one’s entirely on me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Search Results are in lowercased letters
4 participants