Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make more rich graphical window #173

Merged
merged 10 commits into from
Nov 19, 2024
Merged

make more rich graphical window #173

merged 10 commits into from
Nov 19, 2024

Conversation

Code-Hex
Copy link
Owner

@Code-Hex Code-Hex commented Nov 17, 2024

Which issue(s) this PR fixes:

Fixes #35 #150

Additional documentation

A toolbar has been added to the window for the GUI to allow zooming by default. This zooming functionality has been adapted in the same way as the Screen Sharing App, which is installed built-in in macOS.

In addition, I have added 2 additional options for customizing the window:

  • Added WithWindowTitle option to display window title (the default is disabled)
  • Added WithController option to handle virtual machine via window toolbar (the default is disabled)
CleanShot.2024-11-18.at.01.28.02.mp4

@Code-Hex Code-Hex requested a review from AkihiroSuda November 17, 2024 16:51
virtualization_11.m Outdated Show resolved Hide resolved
Copy link
Collaborator

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The zoom button looks like a "search" button
  • Would it be possible to open a confirmation dialog box when the power button is clicked?

@Code-Hex
Copy link
Owner Author

Code-Hex commented Nov 19, 2024

@AkihiroSuda Thanks your advice!
I changed zoom icon magnifyingglass -> plus.magnifyingglass and I have added a dialog like below:
CleanShot 2024-11-19 at 22 29 21@2x

@Code-Hex
Copy link
Owner Author

I have also fixed issue #150 with 8dcce62

@cfergeau Could you confirm this?

@AkihiroSuda AkihiroSuda merged commit 179f6bb into main Nov 19, 2024
8 checks passed
@AkihiroSuda AkihiroSuda deleted the add/graphic-display-rich branch November 19, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants