-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added NetworkDeviceAttachmentWasDisconnected api #169
Changes from 6 commits
8e9c1ff
11f8101
9f38783
f70b693
6f19063
1eafd18
4be99b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package sliceutil | ||
|
||
// FindValueByIndex returns the value of the index in s, | ||
// or -1 if not present. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't seem returning -1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I fixed 4be99b6 |
||
func FindValueByIndex[S ~[]E, E any](s S, idx int) (v E) { | ||
for i := range s { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this for loop really necessary? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed, I will remove it. |
||
if i == idx { | ||
return s[i] | ||
} | ||
} | ||
return v | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package sliceutil_test | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/Code-Hex/vz/v3/internal/sliceutil" | ||
) | ||
|
||
func TestFindValueByIndex(t *testing.T) { | ||
tests := []struct { | ||
name string | ||
slice []int | ||
index int | ||
expected int | ||
}{ | ||
{ | ||
name: "Index within range", | ||
slice: []int{1, 2, 3, 4, 5}, | ||
index: 2, | ||
expected: 3, | ||
}, | ||
{ | ||
name: "Index out of range", | ||
slice: []int{1, 2, 3, 4, 5}, | ||
index: 10, | ||
expected: 0, // default value of int | ||
}, | ||
{ | ||
name: "Negative index", | ||
slice: []int{1, 2, 3, 4, 5}, | ||
index: -1, | ||
expected: 0, // default value of int | ||
}, | ||
{ | ||
name: "Empty slice", | ||
slice: []int{}, | ||
index: 0, | ||
expected: 0, // default value of int | ||
}, | ||
} | ||
|
||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
result := sliceutil.FindValueByIndex(tt.slice, tt.index) | ||
if result != tt.expected { | ||
t.Errorf("FindValueByIndex(%v, %d) = %v; want %v", tt.slice, tt.index, result, tt.expected) | ||
} | ||
}) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to take this concise approach because it is difficult to identify the interface NetworkDeviceAttachment class in the Objective-C world and restore it in the Go world.
This also has the advantage that it is identical to the VirtioNetworkDeviceConfiguration pointer at set time.