Allow to define a list of set_types to exclude #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebbit1q
reviewed
Nov 20, 2023
|
Ok, so no other opinions here for now. We can still discuss and adjust the picks after collecting feedback and seeing it in action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
The amount of included sets can get quite crazy with many many cards. Just two weeks ago there were like 10 sets included in the spoiler file, which can create a bit of a mess.
For most people, gift and promo cards or special sets that are not widely legal or can not be played in limited formats are not of interest at all.
Currently, there is
Wizards Play Network 2024set included with promotional gift cards for example. It can be useful for some to have this, but I like to keep it clean for the huge majority of users. Fewer notifications and popups for new sets in Cockatrice, but more relevant ones.This allows users to run the script more flexible and to their needs.
We currently exclude token only sets already, I included some more very specific ones to narrow it down to the more relevant sets like core, masters, expansion and commander.
Input for excluded list taken from https://scryfall.com/docs/api/sets
Open for your opinions on my picks!
Was not sure if
funnyshould be excluded by default as well.