Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX#363: Enhance Error Handling for Robust API Interactions #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX#363: Enhance Error Handling for Robust API Interactions #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 39 additions & 5 deletions evalai/submissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,43 @@ def push(image, phase, url, public, private):
request_path = URLS.phase_details_using_slug.value
request_path = request_path.format(phase)
response = make_request(request_path, "GET")
challenge_pk = response.get("challenge")
phase_pk = response.get("id")
try:
challenge_pk = response.get("challenge")
except KeyError:
echo(
style(
"\nError: Key 'challenge' not found in response.", fg="red", bold=True
)
)
sys.exit(1)
try:
phase_pk = response.get("id")
except KeyError:
echo(
style(
"\nError: Key 'id' not found in response for phase details.", fg="red", bold=True
)
)
sys.exit(1)

request_path = URLS.challenge_details.value
request_path = request_path.format(challenge_pk)
response = make_request(request_path, "GET")
max_docker_image_size = response.get("max_docker_image_size")
try:
response = make_request(request_path, "GET")
except requests.exceptions.RequestException as err:
echo(err)
sys.exit(1)
try:
max_docker_image_size = response.get("max_docker_image_size")
except KeyError:
echo(
style(
"\nError: Key 'max_docker_image_size' not found in challenge details response.",
fg="red",
bold=True,
)
)
sys.exit(1)

docker_image_size = docker_image.__dict__.get("attrs").get("VirtualSize")
if docker_image_size > max_docker_image_size:
Expand All @@ -137,7 +167,11 @@ def push(image, phase, url, public, private):
request_path = URLS.get_aws_credentials.value
request_path = request_path.format(phase_pk)

response = make_request(request_path, "GET")
try:
response = make_request(request_path, "GET")
except requests.exceptions.RequestException as err:
echo(err)
sys.exit(1)
federated_user = response["success"]["federated_user"]
repository_uri = response["success"]["docker_repository_uri"]

Expand Down