Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMRT Link API client and EPP for fetching run information #586

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Karl-Svard
Copy link
Collaborator

@Karl-Svard Karl-Svard commented Jan 29, 2025

Added

  • Added a client for working with the SMRT Link API
  • Added new EPP for fetching run information from SMRT Link

Changed

  • Refactored the location of modules used for setting up the API connection to StatusDB (cg)

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard Karl-Svard changed the title Add SMRT Link API functionalities and EPPs for post sequencing steps Add SMRT Link API client and EPP for fetching run information Jan 30, 2025
@Karl-Svard Karl-Svard marked this pull request as ready for review January 30, 2025 14:08
@Karl-Svard
Copy link
Collaborator Author

Tests performed on stage

New automation

Get SMRT Link Run Info

bash -c -l "conda activate cg_lims &&  lims -c /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid} udf set fetch-smrtlink-run-information"

Performance

Runs with different setups

Screenshot 2025-01-31 at 10 30 34
Screenshot 2025-01-31 at 10 07 31

When you have an incorrect run name

Screenshot 2025-01-31 at 10 38 58

Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Karl! It seems to work nicely, and well done fixing the issue with the pytest 👏💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants