Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vehicle turrets not cooling down #69551

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix vehicle turrets not cooling down #69551

merged 2 commits into from
Nov 21, 2023

Conversation

actually-a-cat
Copy link
Contributor

@actually-a-cat actually-a-cat commented Nov 19, 2023 •
edited
Loading

Summary

Bugfixes "Fixed laser weapons mounted on vehicles not cooling down"

Purpose of change

Fix #68011

Describe the solution

Run processing on vehicle turrets

Describe alternatives you've considered

Testing

  • turrets cool down
  • player standing on controls hears overheat messages from all turrets
  • player standing on turret hears messages only from that turret
  • cooling down on vehicle takes the same time as a separate item

Additional context

I know literally nothing about vehicle code, please double-check this

After a few hours playtesting this and seeing no problems I'm fairly confident it's all good.

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 19, 2023
@Maleclypse Maleclypse merged commit 3cf64dc into CleverRaven:master Nov 21, 2023
@GuardianDll GuardianDll mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gun overheating mechanic breaks laser turrets
2 participants
@actually-a-cat @Maleclypse