Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch.py fullpath doesn't use realpath #1

Merged
merged 1 commit into from
Oct 2, 2022
Merged

launch.py fullpath doesn't use realpath #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions flyrpc/launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,11 @@

def fullpath(file):
"""
NOTE: if you are getting here because of an import error
you may be using a virtual environment with symlinks.

make a new env with

`python3 -m venv --copies <name_of_ur_venv>`
Instead of undoing the symlinks and getting to the "real path",
maintain symlinks. This avoids the problem caused when using
virtual environments with symlinks to the python executable.
"""
return os.path.realpath(os.path.expanduser(file))
return os.path.expanduser(file)

def launch_server(module_or_filename, new_env_vars=None, server_poll_timeout=10, server_poll_interval=0.1, **kwargs):
# create list to hold command
Expand Down