[ENHANCEMENT] "exclude_involved" added to short events

[jaysoleson]

About The Pull Request

hello! this PR adds an "exclude_involved" parameter to short events, specifically to be utilised in "unknown murder" events. currently, the "the culprit is unknown" murder event shows the murderer in the involved cats buttons, which spoils the mystery!

Why This Is Good For ClanGen

this will solve the issue of unknown murder events being spoiled by the involved cat buttons. additionally, a cat not mentioned in the text being a part of the involved cats is commonly seen as a bug by new players.
this can also provide more writing opportunities for murders with secret culprits.

Proof of Testing

the unknown murder event's involved cat buttons, with the addition to the JSON and without!

and here's what it looks like as part of the event dict:

Changelog/Credits

"Unknown murderers will no longer be involved in their murder event." or somesuch :]

[j-gynn]

Hi! Thank you for your interest in this issue. There is a bit of division within the community as to whether or not "unknown murderer" events should show who the murderer is or not. Some players say no: it's an unknown murderer, the point is that we don't know. Some players say yes: they want to write or draw the story and knowing who did the murdering is important to that - even though the Clan doesn't know.

#3194 discusses this issue and it has been labelled limitation, but as always the problem is a bit more nuanced than that. I wonder if perhaps a clan setting could be created to enable/disable showing the murderer in unknown murderer events...?

[scribblecrumb]

Even if we table the issue of player murder awareness, this is still a good parameter to have. It's some added functionality that I'm certain can be used in other events.

We actually have a less-functional version of it via a new_cat tag ("unknown" i think?) that obv can only be used for a new cat. I'd love to see this implemented in a way that allows its use in patrols as well, then we could just remove that new_cat tag, as this is a more versatile use of it.

Also a reminder that this should be added to the relevant doc files for event writing.

[jaysoleson]

Hi! Thank you for your interest in this issue. There is a bit of division within the community as to whether or not "unknown murderer" events should show who the murderer is or not. Some players say no: it's an unknown murderer, the point is that we don't know. Some players say yes: they want to write or draw the story and knowing who did the murdering is important to that - even though the Clan doesn't know.

#3194 discusses this issue and it has been labelled limitation, but as always the problem is a bit more nuanced than that. I wonder if perhaps a clan setting could be created to enable/disable showing the murderer in unknown murderer events...?

thats fair!! if you did decide to go the route of a clan setting, i think there might have to be a bit of a makeover done to the current murder events (since a clan setting changing the functionality of literally One short event is a bit dramatic lol). maybe the "enable secret murders" toggle could hide ALL murderers from the player until it's been revealed to the Clan too, while playing with it off would only enable murder events that tell you who did it? i'd personally love to play with the secret toggle on!

this would require more secret murders to be written, but i think it's a fun, spooky writing opportunity!