Skip to content
This repository has been archived by the owner on Feb 10, 2025. It is now read-only.

fix: Unit filter and equipment filter option orders #1650

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: Unit filter and equipment filter option orders #1650

merged 2 commits into from
Feb 6, 2025

Conversation

vincit-matu
Copy link
Contributor

🛠️ Changelog

  • Uses alphabetical order for the unit filter options in the search form (client)
  • Uses the unpaginated query for equipments in the reservation unit edit page (admin), also fixing the order

🧪 Test plan

  • Check out the dropdown-menus mentioned above. Alphabetical order is easy to check, and the reservation unit edit page equipments filter should have the same option order as the one on the search page.

🎫 Tickets

  • TILA-3765

@vincit-matu vincit-matu requested a review from joonatank February 4, 2025 08:21
@vincit-matu vincit-matu force-pushed the fix-unit+equipment-order branch from aaf7e42 to deb88cd Compare February 4, 2025 09:41
@vincit-matu vincit-matu changed the title Fix: unit filter and equipment filter option orders fix: Unit filter and equipment filter option orders Feb 4, 2025
@vincit-matu vincit-matu force-pushed the fix-unit+equipment-order branch from deb88cd to e46d9a1 Compare February 4, 2025 12:18
joonatank
joonatank approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joonatank joonatank merged commit b286674 into main Feb 6, 2025
6 checks passed
@joonatank joonatank deleted the fix-unit+equipment-order branch February 6, 2025 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincit-matu @joonatank