Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace: cookiehub with HDS cookie-consent #1629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replace: cookiehub with HDS cookie-consent #1629

wants to merge 1 commit into from

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Jan 24, 2025 •
edited
Loading

🛠️ Changelog

  • replace: cookiehub with HDS cookie-consent

🧪 Test plan

  • Manual testing: check that the different options for cookies work (don't remove mandatory cookies).

🎫 Tickets

Base automatically changed from update-hds-4 to main January 24, 2025 13:39
@joonatank joonatank force-pushed the add-cookie-consent branch 2 times, most recently from b51b166 to 74d4ffa Compare January 24, 2025 14:28
@joonatank joonatank requested a review from vincit-matu January 28, 2025 08:02
@joonatank joonatank marked this pull request as ready for review January 28, 2025 08:02
vincit-matu
vincit-matu approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu