Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pindora client to support seasonal booking and reservation series #1502

Open
wants to merge 2 commits into
base: refactor-reservations-api
Choose a base branch
from
Open

Update Pindora client to support seasonal booking and reservation series #1502

wants to merge 2 commits into from

Conversation

matti-lamppu
Copy link
Collaborator

🛠️ Changelog

  • Updates the Pindora client to support seasonal bookings and reservation series

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu matti-lamppu added the improvement Improves an existing feature label Jan 22, 2025
@matti-lamppu matti-lamppu self-assigned this Jan 22, 2025
@matti-lamppu matti-lamppu marked this pull request as ready for review January 22, 2025 12:34
@matti-lamppu matti-lamppu requested review from ranta and vergama January 22, 2025 12:34
vergama
vergama requested changes Jan 22, 2025
View reviewed changes
Copy link

@vergama vergama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Series and seasonal creation and (more importantly) update should be limited to only their CONFIRMED reservations.

ranta
ranta approved these changes Jan 22, 2025
View reviewed changes
tilavarauspalvelu/integrations/keyless_entry/typing.py


class PindoraReservationSeriesCreateData(TypedDict):
reservation_serie_id: str # uuid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serie

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct according to Pindora's API. I've asked them to change it since we don't use serie as the singular form of series.

tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved
tilavarauspalvelu/integrations/keyless_entry/client.py Outdated Show resolved Hide resolved
@matti-lamppu matti-lamppu force-pushed the refactor-reservations-api branch from 28ff058 to 8aea484 Compare January 23, 2025 06:40
@matti-lamppu matti-lamppu force-pushed the update-pindora-client branch from b777f70 to 54223cf Compare January 23, 2025 06:40
@matti-lamppu matti-lamppu requested review from vergama and ranta January 23, 2025 07:26
@matti-lamppu
Update pindora client to support seasonal booking and reservation series
76ec052
@matti-lamppu
Fix errors in Pindora client
d0417b6 
- Only account for CONFIRMED reservations
- Add PindoraClientError to differentiate non-API errors
- Use `local_iso_format` to format datetimes
- Fix a couple of typos
@matti-lamppu matti-lamppu force-pushed the update-pindora-client branch from 98d9e86 to d0417b6 Compare January 23, 2025 13:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama approved these changes

@ranta ranta Awaiting requested review from ranta

Assignees

@matti-lamppu matti-lamppu

Labels
improvement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matti-lamppu @vergama @ranta