Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP-2220 | Change default value for Helsinki tunnus amr claim #305

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

charn
Copy link
Contributor

@charn charn commented Feb 6, 2024

helusername is deprecated and the new keycloak authentication uses helsinki_tunnus in tunnistamo (which Helsinki profile uses).

Refs: HP-2220

helusername is deprecated and the new keycloak authentication
uses helsinki_tunnus in tunnistamo (which Helsinki profile uses).

Refs: HP-2220
@charn charn requested a review from a team February 6, 2024 17:21
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0095396) 83.96% compared to head (9701341) 83.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   83.96%   83.96%           
=======================================
  Files         170      170           
  Lines        3824     3824           
  Branches      884      884           
=======================================
  Hits         3211     3211           
  Misses        375      375           
  Partials      238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty

@charn charn merged commit b4e531d into main Feb 7, 2024
7 checks passed
@charn charn deleted the HP-2220-helsinki-tunnus-amr-claim branch February 7, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants