Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (HDS-2633) fix e2e screenshots on multiple components #1472

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Feb 7, 2025

Description

Fixes multiple component screenshots with wrong spacings leaving parts out. Add sloMo to all e2e interactions to prevent not-rendered states when taking shots.

Related Issue

Closes HDS-2633

How Has This Been Tested?

  • running tests

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • not needed

Copy link

github-actions bot commented Feb 7, 2025

Test Results

  1 files   68 suites   17m 36s ⏱️
 87 tests  87 ✅ 0 💤 0 ❌
174 runs  174 ✅ 0 💤 0 ❌

Results for commit 36270c7.

Copy link

github-actions bot commented Feb 7, 2025

Preview found from hds-demo docs/preview_1472

Demos

Docs
Core Storybook
React Storybook

Copy link
Contributor

@timwessman timwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@mrTuomoK mrTuomoK merged commit 7dea9ad into development Feb 7, 2025
8 checks passed
@mrTuomoK mrTuomoK deleted the HDS-2633-fix-e2e-tests branch February 7, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants