Hds-1742: build and publish hds-js package #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riippi
approved these changes
Jan 10, 2024
No need for manual lists. Tried also plugin "rollup-plugin-auto-external", but it messes up imports by using sometimes "import '../.../node_modules/x" instead of "import x" It also breaks regular expressions in extrenals-list and babel runtimes are not included. Note: babel/runtime/* are not imported anymore in lib/index.js. Downshift includes them.
exports.ts includes all files exported as hds-js package. To get all login related vanilla js code, the vanilla js had to be split from all exports in the login component. .gitignore and .npmignore are copies of the React version, without some files related only to that package.
hds-js is built like React, but without css. Also dependencies of the hds-js/package.json are updated via rollup, with yarn update:hds-js The code is built with yarn build:hds-js. Practically build/update:hds-js build the same esm version. Update also re-creates the package.json Styles should not be linted with hds-js, so created new scripts from linting.
Added checks to make sure react or css is not included in the hds-js bundle. Also warns/throws if a node_module is bundled.
The bundled cjs/*.* has same filenames as the source. So result would be exports.js.
NikoHelle
force-pushed
the
hds-1742-hds-js-package
branch
from
2f0806b to
6b2221f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vanilla JS package for HDS:
hds-js!The
hds-jsexports code from thehds-react. It has no own source files. Bundled code is hand-picked and added to thepackages/hds-js/index.ts.This way the
hds-jsis very light and does not require tests or dependencies or pipelines.Components, React or CSS are not exported. There are checks to make sure the package has only vanilla js.
Closes https://helsinkisolutionoffice.atlassian.net/browse/HDS-1742
Motivation and Context
CookieConsentread/write functions are needed without React. Non-React parts of theLoginare also bundled.How Has This Been Tested?
The result has been released as
v3.4.0-alpha.6.A vanilla-js app has been created with Vite and is attached to this PR. Unzipit, run
yarnand thenyarn dev.hds-js-test.zip
Add to changelog