Alpha release of the hds-js #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for manual lists. Tried also plugin "rollup-plugin-auto-external", but it messes up imports by using sometimes "import '../.../node_modules/x" instead of "import x" It also breaks regular expressions in extrenals-list and babel runtimes are not included. Note: babel/runtime/* are not imported anymore in lib/index.js. Downshift includes them.
index.ts includes all files to bundle base-package.json is the skeleton for dynamically created package.json
The package is built to the "output"-folder. Renamed "base-package.json" so the "lerna version" works with hds-js
Added checks to make sure react or css is not included in the hds-js bundle. Also warns/throws if a node_module is bundled.
All packages are published the same way - from "lib" with package.json in the root. So hds-js must use same structure or "lerna publish" won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Add to changelog