Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HDS-2057) add ErrorSummary to docs #1200

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Jan 3, 2024

Add ErrorSummary component to doc site.

Description

Self explanatory :)

Related Issue

HDS-2057

How Has This Been Tested?

  • local tests with updated reference images & snapshot

Add to changelog

  • Added needed line to changelog

@mrTuomoK mrTuomoK requested a review from a team January 3, 2024 08:27
Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@mrTuomoK mrTuomoK force-pushed the HDS-2057-error-summary-documentation branch from 01b6e6c to 720030c Compare January 4, 2024 11:21
@Riippi
Copy link
Contributor

Riippi commented Jan 5, 2024

Should this have it's own card in here?
Screenshot 2024-01-05 at 10 24 33

@mrTuomoK
Copy link
Contributor Author

mrTuomoK commented Jan 8, 2024

Should this have it's own card in here? Screenshot 2024-01-05 at 10 24 33

Ah true... need to make, good spotting.

@mrTuomoK
Copy link
Contributor Author

mrTuomoK commented Jan 8, 2024

Hey who makes the image(s) for this? ping @SillanmakiA perhaps? for ErrorSummary component, pull this branch HDS-2057-error-summary-documentation clean & build -> and go to /site and start it.

@SillanmakiA
Copy link
Contributor

Hey who makes the image(s) for this? ping @SillanmakiA perhaps? for ErrorSummary component, pull this branch HDS-2057-error-summary-documentation clean & build -> and go to /site and start it.

I added the image in my commit. Are you @mrTuomoK able to continue from there?

@mrTuomoK
Copy link
Contributor Author

mrTuomoK commented Jan 12, 2024

I'm still to add the images... hung up with other stuff still... <- done
image

@mrTuomoK mrTuomoK force-pushed the HDS-2057-error-summary-documentation branch from 25f7f12 to 780e6bd Compare January 15, 2024 07:41
Copy link
Contributor

@Riippi Riippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mrTuomoK mrTuomoK merged commit cd7fe7c into development Jan 15, 2024
6 checks passed
@mrTuomoK mrTuomoK deleted the HDS-2057-error-summary-documentation branch January 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants