Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-1950 Add missing Next.js & Gatsby snippets #1185

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Riippi
Copy link
Contributor

@Riippi Riippi commented Dec 8, 2023

Description

Add missing Next.js and Gatsby code snippets back to the documentation.
They should be in here https://hds.hel.fi/foundation/guidelines/server-side-rendering/
but were accidentally(?) removed in this commit 9f691db

Related Issue

https://helsinkisolutionoffice.atlassian.net/browse/HDS-1950

How Has This Been Tested?

On local build

Screenshots (if appropriate):

Before:
Screenshot 2023-12-08 at 12 12 20

After:
Screenshot 2023-12-08 at 12 13 23

Add to changelog

  • Added needed line to changelog

Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oukkidou 👍

Copy link
Contributor

@harriplappalainen harriplappalainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guilty here 👋 The snippets were removed accidentally. This works now 🎉

@harriplappalainen harriplappalainen merged commit a8d6c05 into development Dec 15, 2023
5 checks passed
@harriplappalainen harriplappalainen deleted the HDS-1950-Fix-SSR-examples-rendering branch December 15, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants