Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2042 Add aria-current attributes for language buttons #1180

Merged

Conversation

Riippi
Copy link
Contributor

@Riippi Riippi commented Dec 1, 2023

Description

Add the aria-current for the language selector.

Related Issue

https://helsinkisolutionoffice.atlassian.net/browse/HDS-2042

Motivation and Context

With this change the screenreader takes notice what language button is current

How Has This Been Tested?

Voiceover

@Riippi Riippi force-pushed the HDS-2042-Aria-current-missing-from-language-selection branch from 27689ab to c01655d Compare December 1, 2023 12:47
@Riippi Riippi self-assigned this Dec 1, 2023
@Riippi Riippi marked this pull request as ready for review December 1, 2023 13:13
Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, 👍

@Riippi Riippi force-pushed the HDS-2042-Aria-current-missing-from-language-selection branch from c01655d to f7b79f6 Compare December 6, 2023 14:34
@Riippi Riippi merged commit bdcce27 into development Dec 6, 2023
5 checks passed
@Riippi Riippi deleted the HDS-2042-Aria-current-missing-from-language-selection branch December 6, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants