Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIIKUNTA-584 | feat: upgrade to HDS v3.1.0 and HCRC that uses HDS v3.1.0 & update tests #534

Merged
merged 1 commit into from
Nov 14, 2023
Merged

LIIKUNTA-584 | feat: upgrade to HDS v3.1.0 and HCRC that uses HDS v3.1.0 & update tests #534

merged 1 commit into from
Nov 14, 2023

Conversation

karisal-anders
Copy link
Contributor

@karisal-anders karisal-anders commented Nov 4, 2023 •
edited
Loading

Description

NOTE:

  • The visual outlook has been approved by the designer

feat: upgrade to HDS v3.1.0 and HCRC that uses HDS v3.1.0 & update tests

  • upgrade to hds-react 3.1.0
  • upgrade to react-helsinki-headless-cms 1.0.0-alpha229
  • UI components:
    • <Footer> was rebuilt in HDS v3 so needed to make changes to it
    • rename flipHorizontal to flipVertical per HDS v3 release notes
  • tests:
    • update snapshots
      • NOTE: snapshot updating updated suspiciously e.g.
        "tag_hds-tag__label__I6mc8" to "undefined", maybe there's
        something broken?
    • fix browser tests because language selector changed in HCRC's
      Navigation component which is now actually using HDS v3's Header
      component underneath
  • storybook:
    • fix "yarn build-storybook" and "yarn storybook" failing under
      packages/components
      • NOTE: the storybook looks broken but at least it builds and runs
    • add "crypto-browserify" because it was needed by HDS v3
    • fix graphql code generation creating unusable enumeration values
      by making sure the enum keys don't start with a digit

See react-helsinki-headless-cms 1.0.0-alpha229 PR:
City-of-Helsinki/react-helsinki-headless-cms#131

refs LIIKUNTA-584

Issues

Closes

LIIKUNTA-584

Related

Testing

Automated tests

Manual testing

Screenshots

image

Additional notes

@karisal-anders karisal-anders marked this pull request as draft November 4, 2023 16:02
@karisal-anders karisal-anders force-pushed the LIIKUNTA-584-upgrade-to-hds3 branch 2 times, most recently from 87f82f7 to d9f2fd8 Compare November 4, 2023 16:09
@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@karisal-anders karisal-anders force-pushed the LIIKUNTA-584-upgrade-to-hds3 branch from d9f2fd8 to 1b5bfd3 Compare November 4, 2023 16:26
@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@karisal-anders karisal-anders force-pushed the LIIKUNTA-584-upgrade-to-hds3 branch from 1b5bfd3 to f2423f4 Compare November 5, 2023 10:24
@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is failed for https://tapahtumat-pr534.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is failed for https://harrastukset-pr534.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

TestCafe result is failed for https://liikunta-pr534.dev.hel.ninja 😿💢💥💥

@karisal-anders karisal-anders force-pushed the LIIKUNTA-584-upgrade-to-hds3 branch from f2423f4 to d24a510 Compare November 6, 2023 07:03
@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is failed for https://harrastukset-pr534.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

TestCafe result is failed for https://tapahtumat-pr534.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is failed for https://liikunta-pr534.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@karisal-anders karisal-anders force-pushed the LIIKUNTA-584-upgrade-to-hds3 branch 2 times, most recently from 318f1e4 to 42f456f Compare November 6, 2023 16:36
@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr534.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr534.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr534.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@karisal-anders
feat: upgrade to HDS v3.1.0 and HCRC that uses HDS v3.1.0 & update tests
0b52948 
- upgrade to hds-react 3.1.0
- upgrade to react-helsinki-headless-cms 1.0.0-alpha229
- UI components:
  - <Footer> was rebuilt in HDS v3 so needed to make changes to it
  - rename flipHorizontal to flipVertical per HDS v3 release notes
- tests:
  - update snapshots
    - NOTE: **snapshot updating** updated **suspiciously** e.g.
      "tag_hds-tag__label__I6mc8" to **"undefined"**, maybe there's
      something broken?
  - fix browser tests because language selector changed in HCRC's
    Navigation component which is now actually using HDS v3's Header
    component underneath
- storybook:
  - fix "yarn build-storybook" and "yarn storybook" failing under
    packages/components
    - NOTE: the storybook looks broken but at least it builds and runs
  - add "crypto-browserify" because it was needed by HDS v3
  - fix graphql code generation creating unusable enumeration values
    by making sure the enum keys don't start with a digit

See react-helsinki-headless-cms 1.0.0-alpha229 PR:
City-of-Helsinki/react-helsinki-headless-cms#131

refs LIIKUNTA-584
@karisal-anders karisal-anders force-pushed the LIIKUNTA-584-upgrade-to-hds3 branch from 390d8b7 to 0b52948 Compare November 14, 2023 14:12
@karisal-anders
Copy link
Contributor Author

Rebased on main, manually resolved merge conflicts, force pushed changes. Removed part of git commit message to reflect what was already done in main now (i.e. the organisationPrefixes related changes).

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr534.dev.hel.ninja 😆🎉🎉🎉

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr534.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr534.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr534.dev.hel.ninja 😆🎉🎉🎉

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karisal-anders
Copy link
Contributor Author

All the tests passed and the review environments looked ok after rebasing on main.

@karisal-anders karisal-anders merged commit 062939a into main Nov 14, 2023
105 checks passed
@karisal-anders karisal-anders deleted the LIIKUNTA-584-upgrade-to-hds3 branch November 14, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomakela nikomakela nikomakela approved these changes

@melniiv melniiv Awaiting requested review from melniiv

@jakezu jakezu Awaiting requested review from jakezu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karisal-anders @terovirtanen @codecov-commenter @nikomakela