Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linters for HDBT subtheme #790

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Linters for HDBT subtheme #790

merged 7 commits into from
Feb 17, 2025

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 7, 2025 •
edited
Loading

What was done

  • Removed pre-commit and lint-staged modules as we don't need it.
  • Run the linters during npm run build to maintain coding standards

How to test

  • Run nvm use && npm i && npm run build in ./public/themes/custom/hdbt_subtheme and check that the theme building tools works as before.
    • You can test the SCSS linter by changing making a non-valid change to any css attribute - like change the alphabetical order
    • Same goes with JS linter
  • Check that code follows our standards

teroelonen
teroelonen approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

@khalima khalima changed the title Removed pre-commit module Linters for HDBT subtheme Feb 11, 2025
teroelonen
teroelonen approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion this works correctly now 🦖

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khalima khalima merged commit 6f199d5 into dev Feb 17, 2025
3 checks passed
@khalima khalima deleted the UHF-X_uninstall_pre_commit branch February 17, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen