Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11373: Fixed function that removes news filters #1179

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Feb 10, 2025

UHF-11373

What was done

  • Fixed issue where the first news filter got always removed even though second or third etc was pressed

How to install

  • Make sure your Etusivu instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11373
  • If there's only a few news items run drush sapi-rt; drush sapi-c; drush sapi-i; drush cr
  • Run make drush-cr

How to test

  • Go to https://helfi-etusivu.docker.so/fi/uutiset and add some filters to the search
  • Test that you can remove the filters correctly and that the search results update correctly
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1179/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants