Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11329 Visual regression and chart refactor #1175

Merged
merged 25 commits into from
Feb 6, 2025
Merged

UHF-11329 Visual regression and chart refactor #1175

merged 25 commits into from
Feb 6, 2025

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 5, 2025

UHF-11329

What was done

  • Added the embedded content cookie compliance functionality to Chart media type.
  • Use allow attribute in embedded content if available.
  • Skip the HDBT cookie banner element when testing scenarios.
  • Removed customised styles for the helfi_chart specific cookie consent warning.

How to install

How to test

Other PRs

Copy link

github-actions bot commented Feb 5, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

Copy link

github-actions bot commented Feb 5, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

…ray by default and added the askem block, chart and journey planner as exceptions with lighter gray
Copy link

github-actions bot commented Feb 5, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

1 similar comment
Copy link

github-actions bot commented Feb 5, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

Copy link

github-actions bot commented Feb 5, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

Copy link

github-actions bot commented Feb 6, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

Copy link

github-actions bot commented Feb 6, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

1 similar comment
Copy link

github-actions bot commented Feb 6, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

Copy link

github-actions bot commented Feb 6, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a wild ride 🦖

@khalima khalima merged commit fb4210b into main Feb 6, 2025
2 checks passed
@khalima khalima deleted the UHF-11329 branch February 6, 2025 13:35
Copy link

github-actions bot commented Feb 6, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1175/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants