Skip to content

Commit

Permalink
Merge pull request #1172 from City-of-Helsinki/UHF-11325
Browse files Browse the repository at this point in the history
UHF-11325: Adding unique link texts for map skip links
  • Loading branch information
teroelonen authored Feb 4, 2025
2 parents e997096 + 846ad9c commit 29c7151
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 17 deletions.
2 changes: 1 addition & 1 deletion dist/js/embedded-content-cookie-compliance.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 19 additions & 13 deletions src/js/embedded-content-cookie-compliance.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/
// eslint-disable-next-line func-names
(function ($, Drupal, drupalSettings) {

const loadEmbeddedContent = () => {
if (
Drupal.cookieConsent.getConsentStatus(['preferences', 'statistics']) &&
Expand All @@ -28,28 +27,35 @@
skipLinkBefore.href = `#${attributes.skipLinkAfterId}`;
skipLinkBefore.id = attributes.skipLinkBeforeId;


const skipLinkAfter = document.createElement('a');
skipLinkAfter.classList.add('focusable', 'skip-link');
skipLinkAfter.href = `#${attributes.skipLinkBeforeId}`;
skipLinkAfter.id = attributes.skipLinkAfterId;

const containerElement = document.createElement('div');
containerElement.appendChild(iframeElement);
if (attributes.type === 'video') {
containerElement.classList.add('responsive-video-container');
$(`.embedded-content-cookie-compliance.media-${id}`)
.empty()
.append(containerElement)
.removeClass(`media-${id}`);
} else if (attributes.type === 'map') {

if (attributes.type === 'map') {
const $mapContainer = $(`.embedded-content-cookie-compliance.media-${id}`);

// Extract the map name from the wrapping component element.
// Fallback to empty if no title is set.
const mapName = $mapContainer.parent().prevAll('h2').first().text().trim() || '';

containerElement.classList.add('responsive-map-container');
skipLinkAfter.classList.add('skip-link--map--after');
skipLinkBefore.classList.add('skip-link--map--before');
skipLinkAfter.text = Drupal.t('Continue above the map', {}, { context: 'Skip link after the map for the map paragraph' });
skipLinkBefore.text = Drupal.t('Continue below the map', {}, { context: 'Skip link before the map for the map paragraph' });
$(`.embedded-content-cookie-compliance.media-${id}`)
.replaceWith(skipLinkBefore, containerElement, skipLinkAfter);

// Adjust the skip link text based on whether mapName is found.
skipLinkAfter.text = mapName
? Drupal.t('Continue above the @map map', { '@map': mapName }, { context: 'Skip link after the map for the map paragraph' })
: Drupal.t('Continue above the map', {}, { context: 'Skip link after the map for the map paragraph' });

skipLinkBefore.text = mapName
? Drupal.t('Continue below the @map map', { '@map': mapName }, { context: 'Skip link before the map for the map paragraph' })
: Drupal.t('Continue below the map', {}, { context: 'Skip link before the map for the map paragraph' });

$mapContainer.replaceWith(skipLinkBefore, containerElement, skipLinkAfter);
} else if (attributes.type === 'journey_planner') {
containerElement.classList.add('journey-planner-container');
skipLinkAfter.classList.add('skip-link--planner--after');
Expand Down
8 changes: 8 additions & 0 deletions translations/fi.po
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,14 @@ msgctxt "Skip link before the map for the map paragraph"
msgid "Continue below the map"
msgstr "Siirry kartan alapuolelle"

msgctxt "Skip link after the map for the map paragraph"
msgid "Continue above the @map map"
msgstr "Siirry kartan @map yläpuolelle"

msgctxt "Skip link before the map for the map paragraph"
msgid "Continue below the @map map"
msgstr "Siirry kartan @map alapuolelle"

msgctxt "District and project search"
msgid "districts"
msgstr "aluetta"
Expand Down
8 changes: 8 additions & 0 deletions translations/sv.po
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,14 @@ msgctxt "Skip link before the map for the map paragraph"
msgid "Continue below the map"
msgstr "Gå förbi kartan nedåt"

msgctxt "Skip link after the map for the map paragraph"
msgid "Continue above the @map map"
msgstr "Gå förbi kartan @map uppåt"

msgctxt "Skip link before the map for the map paragraph"
msgid "Continue below the @map map"
msgstr "Gå förbi kartan @map nedåt"

msgctxt "District and project search"
msgid "districts"
msgstr "områden"
Expand Down

0 comments on commit 29c7151

Please sign in to comment.