Issue #32: Initial implementation of the non-blocking tagging task allocator. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafa-be
force-pushed
the
task_tagging
branch
from
f6a81ed to
1bc05f0
Compare
rafa-be
commented
Dec 19, 2024
| @@ -4,4 +4,5 @@ graphlib-backport; python_version < '3.9' | |||
| psutil | |||
| pycapnp | |||
| pyzmq | |||
| sortedcontainers | |||
There was a problem hiding this comment.
This does not really add a new dependency, as pycapnp already has it as a dependency.
rafa-be
commented
Dec 19, 2024
| metadata @2 :Data; | ||
| funcObjectId @3 :Data; | ||
| functionArgs @4 :List(Argument); | ||
| tags @2 :List(Text); |
There was a problem hiding this comment.
I'm using Capnp's text strings for tags. Alternatively, we could use UTF-8 encoded bytes.
Signed-off-by: rafa-be <[email protected]>
rafa-be
force-pushed
the
task_tagging
branch
from
1bc05f0 to
07c3696
Compare
sharpener6
reviewed
Jan 22, 2025
| metadata @2 :Data; | ||
| funcObjectId @3 :Data; | ||
| functionArgs @4 :List(Argument); | ||
| tags @2 :List(Text); |
There was a problem hiding this comment.
add tags at last as @5
| queuedTasks @3 :UInt32; | ||
| latencyUS @4 :UInt32; | ||
| taskLock @5 :Bool; | ||
| processors @6 :List(Status.ProcessorStatus); |
There was a problem hiding this comment.
no need shifting fields, put them to the last
|
|
||
| from tests.utility import logging_test_name | ||
|
|
||
| MAX_TASKS_PER_WORKER = 10 |
There was a problem hiding this comment.
move this to default value file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a first implementation of a task allocator that supports tags. Scheduler is still using the old
QueuedAllocator.Once this replaces the old
QueuedAllocator, it will also fix issue #45, as it removes the blocking worker queue.