-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fix examplesW * Fix name of registry_login parameter
- Loading branch information
1 parent
94bd383
commit ec740b0
Showing
3 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,14 +12,14 @@ usage: | |
orbs: | ||
aws-ecr: circleci/[email protected] | ||
# importing aws-cli orb is required for authentication | ||
aws-cli: circleci/aws-cli@4.0 | ||
aws-cli: circleci/aws-cli@5.1 | ||
workflows: | ||
build-and-push-image-with-container-registry-login: | ||
jobs: | ||
- aws-ecr/build_and_push_image: | ||
# must set container registry login to true | ||
container_registry_login: true | ||
container_registry_login_step: | ||
registry_login: | ||
# custom login step for heroku. | ||
- run: docker login -u ${HEROKU_USERNAME} -p ${HEROKU_API_KEY} | ||
# custom login step for GitHub Container Registry. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ usage: | |
orbs: | ||
aws-ecr: circleci/[email protected] | ||
# importing aws-cli orb is required for authentication | ||
aws-cli: circleci/aws-cli@4.0 | ||
aws-cli: circleci/aws-cli@5.1 | ||
jobs: | ||
build-test-then-push-with-buildx: | ||
machine: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ usage: | |
orbs: | ||
aws-ecr: circleci/[email protected] | ||
# Importing aws-cli orb is required | ||
aws-cli: circleci/aws-cli@4.0 | ||
aws-cli: circleci/aws-cli@5.1 | ||
|
||
executors: | ||
base: | ||
|
@@ -23,7 +23,7 @@ usage: | |
auth: | ||
# Add authentication step with OIDC using aws-cli/setup command | ||
- aws-cli/setup: | ||
profile: "OIDC-USER" | ||
profile_name: "OIDC-USER" | ||
role_arn: "arn:aws:iam::123456789012:role/VALID_OIDC_ECR_ROLE" | ||
|
||
# Must use same profile configured in aws-cli/setup command | ||
|