-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1 from ChristopherLinnett/refactor-arrays-to-objects
Refactor arrays to objects
- Loading branch information
Showing
228 changed files
with
2,171 additions
and
942 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# ApneaElearning 2701ICT Griffith University | ||
|
||
This application was created as an assessment piece for Griffith University, Interactive Application Development Course. | ||
This is my first application created using a combination of Ionic/Angular. | ||
|
||
This was a great learning experience, while the final application is functional as intended there were ways I could have simplified the process. | ||
|
||
Data Typing, My data was stored in arrays, initially this was not an issue. But when it came time for deleting and recalculating indexes combined with async functions, managing this data became difficult. | ||
My fix was to change from using arrays to mapping key:value pairs for each user, using string interpolation to read/write to individual users. | ||
|
||
Data Structuring, The data is stored in JSON within a user file and all permissions/courses etc are built into this. Initially I wanted to use a relational database but had not encountered solutions for this yet. | ||
The solution I thought better to implement would work the same way as a relational database, and modelled in the same way. With each Database table as one key:value pair with the data stored as objects as changed earlier. | ||
|
||
Starting with these two options initially would have made for much easier, creation/reading/updating/deleting of all the data and encountering these problems here has given positive insights for future projects. | ||
This has taught me the value of utilising proper planning with UML(or equivelant) diagrams before starting the coding process, and wireframing before even starting the coding process. | ||
Doing this will cut down on the required time to code the project, and increase planning time allowing for a much smoother end product with likely less bugs to fix along the way |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3.58 MB
(21000%)
android/app/src/main/res/drawable-land-xxxhdpi/splash.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+59.7 KB
(1900%)
android/app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+28.3 KB
(1500%)
android/app/src/main/res/mipmap-mdpi/ic_launcher_foreground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+102 KB
(2200%)
android/app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+214 KB
(2300%)
android/app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Binary file modified
BIN
+39.5 KB
(490%)
android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+347 KB
(2400%)
android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Binary file modified
BIN
+69 KB
(540%)
android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+535 Bytes
(170%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+2.53 KB
(220%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+2.53 KB
(220%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+6.69 KB
(300%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+1.16 KB
(190%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+6.28 KB
(310%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+6.28 KB
(310%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+14.5 KB
(370%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+2.53 KB
(220%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+12.6 KB
(370%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+12.6 KB
(370%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+27.8 KB
(460%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+1.42 MB
(1500%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+27.5 KB
(440%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+61.7 KB
(550%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+11.3 KB
(360%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+44.5 KB
(530%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+54.2 KB
(580%)
ios/App/App/Assets.xcassets/AppIcon.appiconset/[email protected]
Oops, something went wrong.
Binary file modified
BIN
+7.64 MB
(19000%)
ios/App/App/Assets.xcassets/Splash.imageset/splash-2732x2732-1.png
Oops, something went wrong.
Binary file modified
BIN
+7.64 MB
(19000%)
ios/App/App/Assets.xcassets/Splash.imageset/splash-2732x2732-2.png
Oops, something went wrong.
Binary file modified
BIN
+7.64 MB
(19000%)
ios/App/App/Assets.xcassets/Splash.imageset/splash-2732x2732.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.