Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delist Firewall setup on systems with Firewalld installed, such as fedora #862

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Angxddeep
Copy link
Contributor

@Angxddeep Angxddeep commented Oct 21, 2024

Type of Change

  • Bug Fix

Description

As Fedora comes with Firewalld preinstalled & preconfigured with rules set for fedora desktop out of the box. Installing ufw on it might conflict with it & is really not needed.

Testing

I have tested it

Impact

Hides firewall setup on fedora systems

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

core/tabs/security/tab_data.toml Outdated Show resolved Hide resolved
@adamperkowski adamperkowski changed the title Delisting Firewall setup on fedora as it conflicts with Firewalld. Delist Firewall setup on fedora as it conflicts with Firewalld. Oct 25, 2024
@lj3954
Copy link
Contributor

lj3954 commented Oct 27, 2024

This is not a refactor, it's a bugfix. The title also should be modified since my proposed changes make this PR delist firewall setup on any system with firewalld installed, with no relevance to the distro.

@Angxddeep Angxddeep changed the title Delist Firewall setup on fedora as it conflicts with Firewalld. Delist Firewall setup on systems with Firewalld installed, such as fedora Oct 27, 2024
@adamperkowski adamperkowski added bug Something isn't working and removed refactor labels Oct 30, 2024
@ChrisTitusTech ChrisTitusTech merged commit 2badbe9 into ChrisTitusTech:main Nov 8, 2024
2 checks passed
@Angxddeep Angxddeep deleted the Testing-#3 branch November 8, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants