Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ollama installation bug #815

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: Ollama installation bug #815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32298af
Update ollama.sh
jeevithakannan2 Oct 13, 2024
191598a
Merge branch 'main' into patch-1
ChrisTitusTech Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/tabs/utils/ollama.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
printf "%b\n" "${GREEN}ollama is already installed.${RC}"
else
printf "%b\n" "${YELLOW}Installing ollama...${RC}"
curl -fsSL https://ollama.com/install.sh | sh
startService ollama
curl -fsSL https://ollama.com/install.sh | "$ESCALATION_TOOL" sh
"$ESCALATION_TOOL" startService ollama
fi
}

Expand Down Expand Up @@ -85,7 +85,7 @@
printf "%b\n" "${installed_models}"

printf "%b\n" "${YELLOW}Custom Models${RC}"
custom_models=$(ollama list | grep 'custom-model-prefix')

Check warning on line 88 in core/tabs/utils/ollama.sh

View workflow job for this annotation

GitHub Actions / Shellcheck 

[shellcheck] reported by reviewdog 🐶
custom_models appears unused. Verify use (or export if used externally).

Raw Output:
./core/tabs/utils/ollama.sh:88:5: warning: custom_models appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)

printf "%b" "Select a model to run: "
printf "%b" "Enter the number corresponding to the model or enter the name of a custom model: "
Expand Down Expand Up @@ -195,7 +195,7 @@
esac

printf "%b\n" "${YELLOW}Press Enter to continue...${RC}"
read -r dummy

Check warning on line 198 in core/tabs/utils/ollama.sh

View workflow job for this annotation

GitHub Actions / Shellcheck 

[shellcheck] reported by reviewdog 🐶
dummy appears unused. Verify use (or export if used externally).

Raw Output:
./core/tabs/utils/ollama.sh:198:17: warning: dummy appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
done
}

Expand Down
Loading