Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quit with CTRL-C when in search #769

Closed

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Oct 5, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Allow exiting linutil with CTRL C when in search mode.

Testing

  • No issues

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@adamperkowski
Copy link
Collaborator

adamperkowski commented Oct 5, 2024

conflicting with #768

@adamperkowski
Copy link
Collaborator

adamperkowski commented Oct 5, 2024

It'd be very incosistant and poor UX to have Ctrl C exit in one situation, abort the command in other, etc.

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupe of #768

@jeevithakannan2
Copy link
Contributor Author

dupe of #768

Not a dupe both have different functionalities

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Oct 5, 2024

It'd be very incosistand and poor UX to have Ctrl C exit in one situation, abort the command in other, etc.

Used to quit major process like force stopping a running cmd or exiting the application

@adamperkowski
Copy link
Collaborator

It'd be very incosistand and poor UX to have Ctrl C exit in one situation, abort the command in other, etc.

Used to quit major process like force stopping a running cmd or exiting the application

I myself hate when it's inconsistant like this and I know a lot of people feel the same frustration when as a new user I KNOW aborting the command by Ctrl C didn't quit the app and I want to abort my search. I try Ctrl C and linutil disintegrates. I'd throw my keyboard out of a window, fix it and go on GitHub to express my frustration.

@lj3954
Copy link
Contributor

lj3954 commented Oct 5, 2024

I don't think it's to be reasonably expected by the user for to exit the entire program while focused on the searchbar. I oppose this change. The proposed code is also an unmaintainable mess.

@jeevithakannan2 jeevithakannan2 deleted the force-quit branch November 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants