-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: Handle temporary directories entirely within core #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep that's good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking the same thing. Nice work
You've got some conflicts in |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!! ayyyyyyyyyyyyyyy mazing !!
Type of Change
Description
Move all logic for handling temporary directories into linutil core. Return a struct containing the vector of tabs along with the private tempdir variable, which is held so that the destructor can be called once tabs are out of scope. Also add back temporary directory prefix ("linutil_scripts") to improve clarity.
Impact
UIs do not need to manually hold onto a tempdir object they have no use for, improving maintainability (resolving regression in #749).
Checklist