Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: Handle temporary directories entirely within core #754

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

lj3954
Copy link
Contributor

@lj3954 lj3954 commented Oct 4, 2024

Type of Change

  • Refactoring

Description

Move all logic for handling temporary directories into linutil core. Return a struct containing the vector of tabs along with the private tempdir variable, which is held so that the destructor can be called once tabs are out of scope. Also add back temporary directory prefix ("linutil_scripts") to improve clarity.

Impact

UIs do not need to manually hold onto a tempdir object they have no use for, improving maintainability (resolving regression in #749).

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that's good

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@cartercanedy cartercanedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking the same thing. Nice work

@adamperkowski adamperkowski changed the title refactor: Handle temporary directories entirely within core refact: Handle temporary directories entirely within core Oct 25, 2024
@adamperkowski
Copy link
Collaborator

You've got some conflicts in state.rs

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Oct 25, 2024

update docgen.rs as well

@adamperkowski adamperkowski added the rust Pull requests that update Rust code label Oct 25, 2024
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!! ayyyyyyyyyyyyyyy mazing !!

@ChrisTitusTech ChrisTitusTech merged commit 6728e7e into ChrisTitusTech:main Nov 6, 2024
2 checks passed
@lj3954 lj3954 deleted the refactor_tempdir branch November 6, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants