allow scrolling past last entry / first entry #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperkowski
requested changes
Oct 2, 2024
lj3954
suggested changes
Oct 2, 2024
There was a problem hiding this comment.
As mentioned in another comment, linutil core will panic on an empty tab array. Better error handling there may be a good idea, but the output of the function should still absolutely be guaranteed to not be empty; otherwise undefined behaviour could occur during UI rendering.
Co-authored-by: Liam <[email protected]>
Co-authored-by: Liam <[email protected]>
|
You missed 2, @lj3954 |
adamperkowski
requested changes
Oct 2, 2024
Co-authored-by: Adam Perkowski <[email protected]>
adamperkowski
requested changes
Oct 2, 2024
Co-authored-by: Adam Perkowski <[email protected]>
No, those are wrong. The item list can be empty if a search term not matching anything is entered. You should get a panic with those changes applied in that case. |
|
Absolutely not. The item list can be empty, since a search can come up with no results. Only the tab list should be expected not to be empty. |
nnyyxxxx
force-pushed
the
scrollpastlastentry
branch
from
c0ec78b to
544cbd4
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
lj3954
approved these changes
Oct 2, 2024
ChrisTitusTech
approved these changes
Oct 31, 2024
|
@nnyyxxxx i meant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
watch the video
regular scrolling and tab scrolling NEEDS to be separated, without separation, we wont be able to properly handle subdir cases
Type of Change
Description
wraps the user to the top of the list or to the bottom of the list depending on where they are at
example:
2024-10-02-01-34-18.mp4