Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dynamic shortcut list sizing #668

Merged
merged 2 commits into from
Sep 28, 2024
Merged

implement dynamic shortcut list sizing #668

merged 2 commits into from
Sep 28, 2024

Conversation

cartercanedy
Copy link
Contributor

Type of Change

  • Bug fix

Description

Makes shortcut list dynamically sized

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@nnyyxxxx
Copy link
Contributor

image
might wanna organize these into a grid like pattern so they dont look messy

@cartercanedy
Copy link
Contributor Author

Good idea, that'll be a little bit longer to get implemented right, though, so this'll at least get the bug sorted

adamperkowski
adamperkowski approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@cartercanedy
Copy link
Contributor Author

Any feedback @lj3954?

@cartercanedy cartercanedy force-pushed the dynamically-resize-legend branch 3 times, most recently from 0765953 to edd8118 Compare September 25, 2024 17:03
@cartercanedy cartercanedy force-pushed the dynamically-resize-legend branch from edd8118 to f1e84bd Compare September 25, 2024 17:26
This was referenced Sep 26, 2024
Closed
Merged
ChrisTitusTech
ChrisTitusTech approved these changes Sep 28, 2024
View reviewed changes
Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Was just thinking about this a couple days ago on a smaller screen.

@ChrisTitusTech ChrisTitusTech merged commit a2480bf into ChrisTitusTech:main Sep 28, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command List cuts off - Needs 3 Lines
4 participants
@cartercanedy @nnyyxxxx @ChrisTitusTech @adamperkowski