Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add scroll #643

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat: Add scroll #643

merged 4 commits into from
Sep 30, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 23, 2024 •
edited
Loading

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Add scroll when running commands.
  • Scroll using Page Up and Page Down.
  • Up and Down arrow keys are not used because it would intercept their functionality in terminal feat: Add scroll #643 (comment)

Testing

  • Works as expected.

Issues / other PRs related

Additional Information

  • The maximum scroll limit is set to 200. Can be increased in future

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@lj3954
Copy link
Contributor

lj3954 commented Sep 23, 2024

Up and down keys are used in the terminal for other behaviour, I'm not sure you'd want to intercept them.

@jeevithakannan2 jeevithakannan2 marked this pull request as draft September 23, 2024 15:04
@jeevithakannan2 jeevithakannan2 marked this pull request as ready for review September 23, 2024 15:34
@ChrisTitusTech ChrisTitusTech merged commit 66b92c8 into ChrisTitusTech:main Sep 30, 2024
1 check passed
@jeevithakannan2 jeevithakannan2 deleted the scroll branch October 1, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll or Navigate to see the output of the executed commands
3 participants
@jeevithakannan2 @lj3954 @ChrisTitusTech