Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting fixes and remove dead code (debug_assertions) #39

Closed
wants to merge 0 commits into from
Closed

Conversation

adamperkowski
Copy link
Collaborator

@adamperkowski adamperkowski commented Jul 16, 2024

Did a few little formatting changes.
There is something like Rust FMT (an official tool, bundled in cargo) which helps you keep your code "clean". You can use cargo fmt --all --check to check your code formatting.
You can also add a GitHub Action that checks it (this one for example). Really can help write better code.

@adamperkowski
Copy link
Collaborator Author

Also, you shouldn't really have dead code in your releases. I understand there's dead code when you're actively working on something, but you can always use debug_assertions or just comment it out so it won't be there when you run cargo build --release and release it.

@adamperkowski adamperkowski changed the title Formatting Fixes Add formatting fixes and remove dead code (debug_assertions) Jul 16, 2024
@adamperkowski
Copy link
Collaborator Author

You can also use ex. cargo clippy for more lints (which returns one warning btw) but I'm leaving it out to you.

@adamperkowski
Copy link
Collaborator Author

This is not a conflict, this is a part of my PR. I have no way of resolving that.

@ChrisTitusTech
Copy link
Owner

Thanks @adamperkowski I'm still looking through the debug_assertions you added and seeing a few build errors. I made a couple commits trying to clear this up, but they still remain. I'll checkout this PR and see if I can troubleshoot further tomorrow.

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix build errors

@adamperkowski
Copy link
Collaborator Author

adamperkowski commented Jul 19, 2024

Sure. I'll update the branch and fix everything in about 5h. (it was not 5h)

EDIT: #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants