Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors with echo commands #33

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

luca0N
Copy link
Contributor

@luca0N luca0N commented Jul 15, 2024

Use the -e option when using the echo command, as backslashes are not interpreted by default. This causes echo to print color escape codes as-is. This PR also replaces existing printf calls with echo for consistency.

Use the `-e' option when using the `echo' command, as backslashes are
not interpreted by default, and replace existing `printf' calls with
`echo' for consistency.
@luca0N
Copy link
Contributor Author

luca0N commented Jul 15, 2024

Some very minor things I've noticed:

  • Some variables are printed with ${VARNAME} instead of $VARNAME. Should all instances of $VARNAME be replaced with ${VARNAME} for consistency?
  • Some files end with a line break (\n), others don't (although all files have Unix line endings). Should we add an \n at the end of all files that don't already have it?

Again, these are minor issues that I decided not to push to this PR so that I could get feedback from Chris and the community, and also for the sake of keeping different submissions separate.

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these additions. I'd say lets standardize things and any inconsistencies can be a separate PR.

@ChrisTitusTech ChrisTitusTech merged commit ca5f72a into ChrisTitusTech:main Jul 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants