Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow different os-releases and hyprland setup #1013
allow different os-releases and hyprland setup #1013
Changes from 14 commits
e009ef0
4b72e84
fc6acb2
45d2995
b6bb227
5391ade
63e0b82
b977560
f8900e4
a776682
c173596
d872d84
599ad20
9e34347
b83cee7
d69c4e1
5731a9b
ad05a0d
7fa4d2d
2b17c04
f37778d
7ec3333
6e20e33
e5fdbff
072c08d
01535e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 11 in core/tabs/system-setup/arch/hyprland-kool.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if cloning fails? maybe due to a wifi problem, or the site could be having problems as seen a couple weeks ago where all git operations suddenly started erroring 404.
Adding error handling for this case would be for the best, since all other commands would also fail.
Check warning on line 5 in core/tabs/system-setup/debian/hyprland-kool-deb.sh
Check warning on line 6 in core/tabs/system-setup/fedora/hyprland-kool-fed.sh
Check warning on line 6 in core/tabs/system-setup/ubuntu/hyprland-kool-ubuntu24.sh